Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build PR doc workflow #1270

Merged
merged 9 commits into from
Aug 11, 2023
Merged

Fix build PR doc workflow #1270

merged 9 commits into from
Aug 11, 2023

Conversation

fxmarty
Copy link
Contributor

@fxmarty fxmarty commented Aug 11, 2023

The Furiosa docbuilding requires secrets.

PRs from forks need to be labeled build-pr-doc to run the workflow.

@fxmarty
Copy link
Contributor Author

fxmarty commented Aug 11, 2023

@regisss I don't get why the build PR doc workflow is not picked now on this PR. I don't expect we need to merge first for it to be triggered. Any idea?

edit: let's just try to merge

@fxmarty fxmarty merged commit a36e4b3 into main Aug 11, 2023
10 checks passed
@fxmarty fxmarty deleted the fix-pr-doc-workflow branch August 11, 2023 10:28
@regisss
Copy link
Contributor

regisss commented Aug 11, 2023

@regisss I don't get why the build PR doc workflow is not picked now on this PR. I don't expect we need to merge first for it to be triggered. Any idea?

edit: let's just try to merge

I think this is because of

 paths:
      - "optimum/**.py"
      - "docs/**.mdx"
      - "docs/**.yml"

Since you just modified GH workflows but nothing in optimum/ or docs/, the PR doc build workflow was not triggered.

@fxmarty
Copy link
Contributor Author

fxmarty commented Aug 11, 2023

I did in 7a4a333

@fxmarty
Copy link
Contributor Author

fxmarty commented Aug 11, 2023

Not sure why but looks to work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants